Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build cgt-calc inside Docker container instead of installing from pipx #563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Build cgt-calc inside Docker container instead of installing from pipx #563

wants to merge 1 commit into from

Conversation

justpresident
Copy link

This allows development without installing any tools locally.

Test plan:

docker build --tag capital-gains-calculator .
docker run --rm -it -v "$PWD":/data capital-gains-calculator:latest
e578f6a392e2:/data# cgt-calc --help

KapJI
KapJI requested changes Sep 28, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@justpresident
Copy link
Author

I suppose it can be merged now?

m01
m01 reviewed Dec 14, 2024
View reviewed changes
Dockerfile
WORKDIR /data
WORKDIR /build

RUN curl -sSL https://install.python-poetry.org | python3 -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about installing poetry using apk instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer apk, it's more clear and easier to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmartinv vmartinv vmartinv left review comments

@m01 m01 m01 left review comments

@KapJI KapJI KapJI requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justpresident @m01 @KapJI @vmartinv @srv-meta