Add calculating dividends gains. #577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cover the double taxation rules and tax treaties for dividends payments - the country of origing for a dividend is determinated by looking at its currency, this is not perfect but works most of the time (will not work for example for all EU countries using the same currency - this will need to be handled later on separately).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover the double taxation rules and tax treaties for dividends payments - the country of origin for a dividend is determinated by looking at its currency, this is not perfect but works most of the time (will not work for example for all EU countries using the same currency - this will need to be handled later on separately).
I've added a simple validation check which compares the tax at source with a one expected for the detected country which should remove (but not fix) some of the invalid matches.
The code will generate a similar pdf report as for capital gains. Right now only treaty with US and Poland are added to the calculations.