Add info about min and max chars to interview message

KarlOfDuty · Jan 20, 2025 · 2229996 · 2229996
1 parent a23ce97
commit 2229996
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/Interviews/Interview.cs b/Interviews/Interview.cs
@@ -93,6 +93,9 @@ public bool TryGetReferencedStep(Dictionary<string, InterviewStep> definitions,
 // The entire interview tree is serialized and stored in the database to record responses as they are made.
 public class InterviewStep
 {
+    public const int DEFAULT_MAX_FIELD_LENGTH = 1024;
+    public const int DEFAULT_MIN_FIELD_LENGTH = 0;
+
     // Title of the message embed.
     [JsonProperty("heading")]
     public string heading;

diff --git a/Interviews/Interviewer.cs b/Interviews/Interviewer.cs
@@ -289,7 +289,7 @@ public static async Task ProcessResponseMessage(DiscordMessage answerMessage)
         }
 
         // The length requirement is less than 1024 characters, and must be less than the configurable limit if it is set.
-        int maxLength = Math.Min(currentStep.maxLength ?? 1024, 1024);
+        int maxLength = Math.Min(currentStep.maxLength ?? InterviewStep.DEFAULT_MAX_FIELD_LENGTH, InterviewStep.DEFAULT_MAX_FIELD_LENGTH);
 
         if (answerMessage.Content.Length > maxLength)
         {
@@ -303,7 +303,7 @@ public static async Task ProcessResponseMessage(DiscordMessage answerMessage)
             return;
         }
 
-        if (answerMessage.Content.Length < (currentStep.minLength ?? 0))
+        if (answerMessage.Content.Length < (currentStep.minLength ?? InterviewStep.DEFAULT_MIN_FIELD_LENGTH))
         {
             DiscordMessage lengthMessage = await answerMessage.RespondAsync(new DiscordEmbedBuilder
             {
@@ -597,7 +597,16 @@ private static async Task SendNextMessage(Interview interview, DiscordChannel ch
                                            string.IsNullOrWhiteSpace(step.selectorPlaceholder) ? "Select a user or role..." : step.selectorPlaceholder));
                 break;
             case StepType.TEXT_INPUT:
-                embed.WithFooter("Reply to this message with your answer. You cannot include images or files.");
+                string lengthInfo;
+                if (step.minLength != null)
+                {
+                    lengthInfo = " (" + step.minLength + "-" + (step.maxLength ?? InterviewStep.DEFAULT_MAX_FIELD_LENGTH) + " characters)";
+                }
+                else
+                {
+                    lengthInfo = " (Maximum " + (step?.maxLength ?? InterviewStep.DEFAULT_MAX_FIELD_LENGTH) + " characters)";
+                }
+                embed.WithFooter("Reply to this message with your answer" + lengthInfo + ". You cannot include images or files.");
                 break;
             case StepType.INTERVIEW_END:
             case StepType.ERROR: