Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

partially resolve #100 (bucket_stat) #113

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

nurzhan-saktaganov
Copy link
Collaborator

@nurzhan-saktaganov nurzhan-saktaganov commented Dec 13, 2024

  • custom msgpackv5 decoders
  • use StorageCallVShardError instead of bucketStatError

What has been done? Why? What problem is being solved?

I didn't forget about (remove if it is not applicable):

Related issues:

@nurzhan-saktaganov nurzhan-saktaganov changed the base branch from nsaktaganov_a_little_refactor to master December 13, 2024 22:43
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_100_for_bucket_stat branch from 741c00a to f270e26 Compare December 13, 2024 22:45
@nurzhan-saktaganov nurzhan-saktaganov marked this pull request as ready for review December 13, 2024 22:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 54.54545% with 30 lines in your changes missing coverage. Please review.

Project coverage is 68.37%. Comparing base (a486c03) to head (300523f).

Files with missing lines Patch % Lines
vshard.go 42.30% 10 Missing and 5 partials ⚠️
replicaset.go 63.15% 10 Missing and 4 partials ⚠️
discovery.go 50.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   68.02%   68.37%   +0.35%     
==========================================
  Files          13       13              
  Lines        1301     1344      +43     
==========================================
+ Hits          885      919      +34     
- Misses        363      367       +4     
- Partials       53       58       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nurzhan-saktaganov nurzhan-saktaganov changed the title WIP: partially resolve #100 partially resolve #100 Dec 13, 2024
@nurzhan-saktaganov nurzhan-saktaganov changed the title partially resolve #100 partially resolve #100 (bucket_stat) Dec 13, 2024
vshard.go Outdated Show resolved Hide resolved
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_100_for_bucket_stat branch 2 times, most recently from af8a5c1 to 87bd928 Compare December 17, 2024 11:46
* custom msgpackv5 decoders
* use StorageCallVShardError instead of bucketStatError
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktaganov_resolve_issue_100_for_bucket_stat branch from 87bd928 to 300523f Compare December 17, 2024 11:48
@KaymeKaydex KaymeKaydex merged commit 0a8677f into master Dec 17, 2024
8 checks passed
@nurzhan-saktaganov nurzhan-saktaganov deleted the nsaktaganov_resolve_issue_100_for_bucket_stat branch December 17, 2024 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a single error/response type with states and do decoding once
3 participants