Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify and footnote superscript styles to match LaTeX theme #172

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

Linho1219
Copy link
Contributor

Remove footnote superscript background and padding; adjust brackets and spacing of footnote labels

Note: In the contribution guidelines, PRs should be submitted to the develop branch. However, there's no branch named develop here now, so I submitted it to the main branch. The possible reason may be that the develop branch has been deleted, and the documentation has not been updated. If you believe submitting directly to the main branch is inappropriate, please let me know which branch I should submit to and close this PR.

Remove footnote superscript background and padding; adjust brackets and spacing of footnote labels
@Keldos-Li Keldos-Li added the 🛠 enhancement PR: new feature or request label Dec 17, 2024
@RalXYZ
Copy link
Collaborator

RalXYZ commented Dec 17, 2024

Note: In the contribution guidelines, PRs should be submitted to the develop branch. However, there's no branch named develop here now, so I submitted it to the main branch. The possible reason may be that the develop branch has been deleted, and the documentation has not been updated. If you believe submitting directly to the main branch is inappropriate, please let me know which branch I should submit to and close this PR.

@Linho1219 Thank you for respecting our contribution guidelines. After reviewing them, I found that some information was outdated, and I have made the necessary updates. You do not need to submit a PR to the develop branch.

From my side, there are no issues with the process. Regarding the functionality of this PR (whether it meets the expectations), please @Keldos-Li review it.

@RalXYZ RalXYZ requested a review from Keldos-Li December 17, 2024 11:53
@Keldos-Li
Copy link
Owner

Keldos-Li commented Dec 17, 2024

Thank you! I see that since we have started working on the footnote section, we might as well complete the work in this PR. I looked at the remaining tasks, which might include:

  • Add [] before and after sup label as well
  • Adjust the paragraph style of the endnote block to avoid excessive line spacing
  • footnote may exceed one line and need indentation adjustment

I expect to start trying to improve these features tomorrow and prepare to commit directly to your branch. If you have time, you can also work on improving the submission first! Once these tasks are completed, we will merge it into main~ Thanks again~

@Keldos-Li Keldos-Li self-assigned this Dec 17, 2024
Copy link
Owner

@Keldos-Li Keldos-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also @Linho1219.
我还是用中文了,各位可以看看现在的效果,如果之后检查没什么问题就以这个合并啦?

@Keldos-Li Keldos-Li requested a review from RalXYZ December 19, 2024 08:23
@RalXYZ RalXYZ self-assigned this Dec 19, 2024
Copy link
Owner

@Keldos-Li Keldos-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

导出表现错误。等我再修……

@Linho1219
Copy link
Contributor Author

应当是 Typora 的部分内置样式采用了 @media print。过两天找一找

Keldos-Li
Keldos-Li previously approved these changes Dec 27, 2024
Copy link
Owner

@Keldos-Li Keldos-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改好了,各位重新review一下

@RalXYZ RalXYZ merged commit c500a46 into Keldos-Li:main Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 enhancement PR: new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants