feat(Lucene): create contentType multi select for admin ui #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seangwright
reviewed
Mar 27, 2024
Co-authored-by: Sean G. Wright <[email protected]>
fialafilip
approved these changes
Mar 28, 2024
| import { IoCheckmarkSharp } from 'react-icons/io5'; | ||
| import { MdOutlineCancel } from 'react-icons/md'; | ||
| import { RxCross1 } from 'react-icons/rx'; | ||
| import Select, { type ActionMeta, type ClearIndicatorProps, components, type CSSObjectWithLabel, type GroupBase, type MultiValue, type MultiValueRemoveProps, type OptionProps, type StylesConfig } from 'react-select'; // eslint-disable-line sort-imports |
There was a problem hiding this comment.
We don't need to disable the eslint rule here, just fix the order of imported types.
| </Stack> | ||
| ); | ||
| const customStyle: StylesConfig<OptionType, true, GroupBase<OptionType>> = { | ||
| control: (styles, { isFocused }) => ({ // eslint-disable-line @typescript-eslint/consistent-type-assertions |
There was a problem hiding this comment.
In this case it would make a sense to disable consistent-type-assertions for the whole customStyle block with
/* eslint-disable @typescript-eslint/naming-convention */
..... block code ....
/* eslint-enable @typescript-eslint/naming-convention */
| <div className="label-wrapper___AcszK"> | ||
| <label className="label___WET63">Included content types</label> | ||
| </div> | ||
| <Select<OptionType, true> |
There was a problem hiding this comment.
Is it necessary to explicitly define generic types here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Create multi-select for Content Types in Admin UI used to select content types for a specific path used for indexing
Checklist