Fix/hardcoded currency #14

martinkyjac · 2024-07-29T08:47:13Z

Motivation

Which issue does this fix? Fixes #10
Added new settings to appsettings.json

Code follows coding conventions held in this repo
Automated tests have been added
Tests are passing
Docs have been updated (if applicable)
Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

README.md

examples/DancingGoat-Shopify/appsettings.json

src/Kentico.Xperience.Shopify/Config/ShopifyIntegrationSettingsService.cs

…Config

martinkyjac added 6 commits July 26, 2024 15:54

Add new configuration section

dedd6b2

Retrieve website channel config from configuration

e321e23

Remove static currency codes and replace with value from configuration

e55802a

Add new setting description into readme

f5cb431

Update readme

db8d50a

Add currency limitations

8a0de8f

martinkyjac changed the base branch from main to feat/XbyK_Shopify_integration July 29, 2024 09:29

martinkyjac changed the base branch from feat/XbyK_Shopify_integration to main July 29, 2024 10:19

michalJakubis requested a review from DanielJurcaBS July 30, 2024 10:29

DanielJurcaBS self-assigned this Jul 30, 2024

DanielJurcaBS reviewed Jul 31, 2024

View reviewed changes

martinkyjac added 3 commits August 1, 2024 09:44

Fix typo

815d80e

Change name ShopifyWebsiteChannelsConfig to CMSShopifyWebsiteChannels…

602c161

…Config

Use option monitor's current value in constructor

16ff840

martinkyjac requested a review from michalJakubis August 1, 2024 08:32

martinkyjac assigned michalJakubis and unassigned DanielJurcaBS Aug 1, 2024

michalJakubis approved these changes Aug 1, 2024

View reviewed changes

michalJakubis merged commit 3650b78 into main Aug 1, 2024
1 check passed

michalJakubis deleted the fix/hardcoded-currency branch August 1, 2024 10:31