Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-3680] Sync ConnectWise configuration records #441

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

kti-matt
Copy link
Collaborator

No description provided.

@kti-matt
Copy link
Collaborator Author

@zeryabkhan91 Two issues to fix:

  1. It doesn't properly filter on company. Notice in the example below I try to filter on company id=1, but it returns a result from company id=10.
  2. I don't believe it pages the configurations results, so it would never get more than 50 at a time. I guess it should have a way for the caller to specify the page number.

@zeryab-topleft zeryab-topleft force-pushed the 3680-sync-connectwise-configuration-records branch from a005d30 to deb2e98 Compare September 18, 2024 15:09
@zeryab-topleft zeryab-topleft force-pushed the 3680-sync-connectwise-configuration-records branch from deb2e98 to 99c4e14 Compare September 19, 2024 13:31
@kti-sam
Copy link
Contributor

kti-sam commented Sep 27, 2024

It looks like it will still only ever fetch the first page of results, slack me and we can discuss if you need any help.

@zeryab-topleft
Copy link
Contributor

It looks like it will still only ever fetch the first page of results, slack me and we can discuss if you need any help.

I have added pagination same as we are doing on other APIs by setting should_page to True, now results are returned based on page & pageSize

@kti-sam kti-sam merged commit b45e8d4 into master Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants