hwdetector #7
Open
hwdetector #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevgen Kovalyov <[email protected]>
Signed-off-by: Kyryl Krynychnyi <[email protected]>
Create two tmp files. Redirect an output of ls /dev to these files and compare them. If the script is interrupted or exited, delete tmp files Signed-off-by: Kyryl Krynychnyi <[email protected]>
USB flash detector is a result of comparison of outputs of ls /dev/sd[a-z]. Change output format and add delay. Signed-off-by: Kyryl Krynychnyi <[email protected]>
i2c detector checks the output of i2cdetect -l SD card detector checks the output of ls /dev Signed-off-by: Kyryl Krynychnyi <[email protected]>
Signed-off-by: Kyryl Krynychnyi <[email protected]>
yekovalyov
reviewed
Feb 5, 2020
yekovalyov
added
question
Signed-off-by: Kyryl Krynychnyi <[email protected]>
Kyryl3231
added
ready for review
and removed
question
yekovalyov
reviewed
Feb 6, 2020
hwdetect/hwdetect.sh
Outdated
| fi | ||
|
|
||
| sleep 1 | ||
| trap 'rm -f $usb0 $usb1 $flash0 $flash1 $i2c0 $i2c1 $sd0 $sd1 && echo -e "\n***********Detection ended***********" && exit' 2 3 15 |
There was a problem hiding this comment.
Is it required to configure signal handlers every second? What will happen in case of program break before end of loop?
yekovalyov
added
question
Signed-off-by: Kyryl Krynychnyi <[email protected]>
Kyryl3231
added
ready for review
and removed
question
yekovalyov
reviewed
Feb 6, 2020
hwdetect/hwdetect.sh
Outdated
| @@ -47,6 +47,8 @@ else | |||
| fi | |||
| echo | |||
|
|
|||
| trap 'rm -f $usb0 $usb1 $flash0 $flash1 $i2c0 $i2c1 $sd0 $sd1 && echo -e "\n***********Detection ended***********" && exit' 2 3 15 | |||
There was a problem hiding this comment.
This line is too long. Is it possible to fit it to 80 columns by adding some variable like ALL_TMP_FILES or/and MSG_TEXT?
yekovalyov
added
question
Signed-off-by: Kyryl Krynychnyi <[email protected]>
Signed-off-by: Kyryl Krynychnyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.