Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to flysystem v3 #182

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

upgrade to flysystem v3 #182

wants to merge 2 commits into from

Conversation

marufmax
Copy link
Contributor

Summary

Currently this middleware supporting only flysystem v1 was released 8 years ago(19th of January in 2015). This PR added support for newer version flysystem v3

@Kevinrob
Copy link
Owner

Thank you for this PR!

The CI fail because we support PHP 7.
league/flysystem[3.16.0, ..., 3.17.0] require php ^8.0.2 -> your php version (7.2.34) does not satisfy that requirement.
But PHP 7 is end-of-life. So maybe we can drop it? What do you think?

@marufmax
Copy link
Contributor Author

I think dropping support for PHP 7 would be a breaking change to this plugin. Flysystem v2 supports PHP 7.2. If you agree, I can create a separate PR to release a new version with Flysystem v2. Then we can release another version with PHP 8 and Flysystem v3.

@marufmax marufmax mentioned this pull request Oct 13, 2023
@Kevinrob
Copy link
Owner

I think dropping support for PHP 7 would be a breaking change to this plugin. Flysystem v2 supports PHP 7.2. If you agree, I can create a separate PR to release a new version with Flysystem v2. Then we can release another version with PHP 8 and Flysystem v3.

The support of PHP <8 is now dropped on the master branch.
@marufmax Can you update your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants