ab#68542b

.github/workflows/keyfactor-starter-workflow.yml

@@ -11,9 +11,10 @@ on:
 
 jobs:
   call-starter-workflow:
-    uses: keyfactor/actions/.github/workflows/starter.yml@v2
+    uses: keyfactor/actions/.github/workflows/starter.yml@3.1.2
     secrets:
       token: ${{ secrets.V2BUILDTOKEN}}
       APPROVE_README_PUSH: ${{ secrets.APPROVE_README_PUSH}}
       gpg_key: ${{ secrets.KF_GPG_PRIVATE_KEY }}
       gpg_pass: ${{ secrets.KF_GPG_PASSPHRASE }}
+      scan_token: ${{ secrets.SAST_TOKEN }}

CHANGELOG.md

@@ -1,2 +1,7 @@
-1.0.0
+v1.1.0
+- Bug fix to return true for private key entry during inventory
+- Add dual build for .net6/8
+- Convert README to use doctool
+
+v1.0.0
 - Initial release

DellIdrac/DellIDRACOrchestrator.csproj

@@ -1,19 +1,20 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
-    <TargetFramework>net6.0</TargetFramework>
+    <AppendTargetFrameworkToOutputPath>true</AppendTargetFrameworkToOutputPath>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
     <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
+    <ImplicitUsings>disable</ImplicitUsings>
   </PropertyGroup>
 
   <ItemGroup>
     <PackageReference Include="Keyfactor.Logging" Version="1.1.1" />
     <PackageReference Include="Keyfactor.Orchestrators.IOrchestratorJobExtensions" Version="0.7.0" />
     <PackageReference Include="Portable.BouncyCastle" Version="1.9.0" />
-  </ItemGroup>
 
-  <Target Name="PostBuild" AfterTargets="PostBuildEvent">
-    <Exec Command="echo F | xcopy &quot;$(ProjectDir)manifest.json&quot; &quot;$(TargetDir)\manifest.json&quot; /Y" />
-  </Target>
+    <None Update="manifest.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
+  </ItemGroup>
 
 </Project>

DellIdrac/IdracClient.cs

@@ -58,7 +58,7 @@ internal List<CurrentInventoryItem> GetCerts(int i)
                 {
                     Alias = $"{i}.{Array.IndexOf(certs, c)}",
                     Certificates = new List<string>() { c },
-                    PrivateKeyEntry = false
+                    PrivateKeyEntry = true
                 }).ToList();
             }
             catch (Exception e)

docsource/content.md

@@ -0,0 +1,21 @@
+## Overview
+
+The Integrated Dell Remote Access Controller (iDRAC) Orchestrator Extension supports the following use cases:
+
+- Inventorying the iDRAC instance's server certificate and importing it into Keyfactor Command for management
+- Adding or Replacing an existing or newly enrolled certificate and private key to an existing iDRAC instance.  To replace an existing server certificate, the Ovewrite flag in Keyfactor Command must be selected.
+
+Use cases NOT supported by the iDRAC Orchestrator Extension:
+
+- Removing a server certificate from an iDRAC instance.
+- Inventorying or Managing any other certificate type on an iDRAC intance.
+
+Special Notes:
+* When adding or replacing the server certificate, there will be a few minute delay as the iDRAC instance will restart.  As a result, it may take a few minutes before the new certificate is reflected in subsequent Inventory jobs.
+* When replacing an existing server certificate, the Overwrite checkbox must be selected/checked.  When this checkbox is selected, Keyfactor Command may require you to enter an alias.  This alias is not used by the orchestrator extension, so just enter any value.
+
+
+## Requirements
+
+1. The Orchestrator must run on a Windows Server machine with the [Racadm CLI utility](https://www.dell.com/support/home/en-us/drivers/driversdetails?driverid=8gmf6) installed, configured to reach the target iDRAC instance.  The Orchestrator must have read and write access to the folder where racadm.exe is installed.
+2. A user id must be set up in iDRAC with minimum privileges of "Configure".  This will be used by the Racadm utility to manage the store.

docsource/idrac.md

@@ -0,0 +1 @@
+## Overview

integration-manifest.json

@@ -8,27 +8,12 @@
   "link_github": true,
   "update_catalog": true,
   "release_dir": "DellIdrac/bin/Release",
+  "release_project": "DellIdrac/DellIDRACOrchestrator.csproj",
   "about": {
     "orchestrator": {
       "UOFramework": "10.4",
       "keyfactor_platform_version": "10.3",
       "pam_support": true,
-      "win": {
-        "supportsCreateStore": false,
-        "supportsDiscovery": false,
-        "supportsManagementAdd": true,
-        "supportsManagementRemove": false,
-        "supportsReenrollment": false,
-        "supportsInventory": true
-      },
-      "linux": {
-        "supportsCreateStore": false,
-        "supportsDiscovery": false,
-        "supportsManagementAdd": false,
-        "supportsManagementRemove": false,
-        "supportsReenrollment": false,
-        "supportsInventory": false
-      },
       "store_types": [
         {
           "Name": "iDRAC",
@@ -42,7 +27,30 @@
             "Enrollment": false,
             "Remove": false
           },
-          "Properties": [],
+          "Properties": [
+            {
+              "Name": "ServerUsername",
+              "DisplayName": "Server Username",
+              "Type": "Secret",
+              "DependsOn": "",
+              "DefaultValue": "",
+              "Required": true,
+              "IsPAMEligible": true,
+              "Description": "The user ID (or, if using a PAM provider, the key pointing to the user ID) to log into the iDRAC instance being managed."
+            },
+            {
+              "Name": "ServerPassword",
+              "DisplayName": "Server Password",
+              "Type": "Secret",
+              "DependsOn": "",
+              "DefaultValue": "",
+              "Required": true,
+              "IsPAMEligible": true,
+              "Description": "The password (or, if using a PAM provider, the key pointing to the password) for the user ID above."
+            }
+          ],
+          "ClientMachineDescription": "The IP address of the iDRAC instance being managed.",
+          "StorePathDescription": "Enter the full path where the Racadm executable is installed on the orchestrator server.  See [Requirements & Prerequisites](#requirements-&-prerequisites) above for more details.",
           "EntryParameters": [],
           "PasswordOptions": {
             "EntrySupported": false,