-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize GitHub CI #467
Modernize GitHub CI #467
Conversation
The current ones are deprecated because running on unsupported Node 12.
Allow an incoming ssh connection after the spec compilation for inspection in case in fails.
3ad18d3
to
0f5b238
Compare
It looks like all the branches for SYCL Next and SYCL 2020 have been renamed compared to https://gitlab.khronos.org/sycl/Specification/-/wikis/process/git |
Do you still think we need this PR @keryell ? I did the "modernization" part a while ago. The other changes in this PR add some debugging stuff to the CI. I've been reluctant to merge that because I'm not sure if there is a security impact. Investigating has been low priority for me because I haven't had a need to run an interactive debugger in the CI job. |
# SHA corresponds to tag "asciidoctor-spec.20240727". | ||
container: khronosgroup/docker-images@sha256:089687083ceb36483a3917389e4278718ab19c594099634f5dd80e22540c960f | ||
# Use Khronos container with asciidoctor toolchain preinstalled | ||
container: khronosgroup/docker-images:asciidoctor-spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a merge mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this from my PR as I thought that we might forget about jumping the hash, even if it is more secure to have a fixed hash.
OK, closing as I might not need to debug this myself anymore. |
The current ones are deprecated because running on unsupported Node 12.