Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that VUID-RuntimeSpirv-x-06432 applies only to compute shaders #2199

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Aug 21, 2023

Both VUID-RuntimeSpirv-TaskEXT-07294 and VUID-RuntimeSpirv-MeshEXT-07298 specify that the requirement only applies to task and mesh shaders, respectively, but VUID-RuntimeSpirv-x-06432 does not specify that it applies only to compute shaders. Since maxComputeWorkGroupInvocations is defined elsewhere as

the maximum total number of compute shader invocations in a single local workgroup

this seems like an omission. This PR adds it, using the first two VUIDs as a template.

I've also given the same treatment to VUID-RuntimeSpirv-x-06429, VUID-RuntimeSpirv-x-06430 and VUID-RuntimeSpirv-x-06431, regarding the maxComputeWorkGroupSize limit.

@oddhack
Copy link
Contributor

oddhack commented Aug 21, 2023

@spencer-lunarg please take a look.

Copy link

@spencer-lunarg spencer-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - This is just making the VU wording consistent with the Mesh/Task shaders VUs

@oddhack
Copy link
Contributor

oddhack commented Aug 21, 2023

LGTM - This is just making the VU wording consistent with the Mesh/Task shaders VUs

OK. I think we can just sign it off for the next spec update, then.

@oddhack oddhack added this to the Signed-off to Merge milestone Aug 21, 2023
@oddhack oddhack merged commit 9f0918d into KhronosGroup:main Aug 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants