bp: Remove simple derived state objects #9486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 375602. |
|
CI Vulkan-ValidationLayers build # 19114 running. |
|
CI Vulkan-ValidationLayers build # 19114 failed. |
jeremyg-lunarg
force-pushed
the
jeremyg-pd-state
branch
from
d3c8c80 to
f441a3f
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 375625. |
|
CI Vulkan-ValidationLayers build # 19115 running. |
|
CI Vulkan-ValidationLayers build # 19115 failed. |
spencer-lunarg
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
@jeremyg-lunarg trying to be the git blame for Best Practice now too!!
These are fairly simple and not likely to cause performance problems. Just get rid of them so that it is easier to change how state tracking works. Image and CommandBuffer are a completely different story...
jeremyg-lunarg
force-pushed
the
jeremyg-pd-state
branch
from
f441a3f to
461da44
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 376313. |
|
CI Vulkan-ValidationLayers build # 19128 running. |
|
CI Vulkan-ValidationLayers build # 19128 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 376410. |
|
CI Vulkan-ValidationLayers build # 19134 running. |
|
CI Vulkan-ValidationLayers build # 19134 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fairly simple and not likely to cause performance problems. Just get rid of them so that it is easier to change how state tracking works.
Image and CommandBuffer are a completely different story...