layers: Improve Fragment Density Map Offset messages #9510
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 378515. |
| "VkPhysicalDeviceFragmentDensityMapOffsetPropertiesQCOM": {}, | ||
| "VkPhysicalDeviceFragmentDensityMapOffsetPropertiesQCOM": { | ||
| "fragmentDensityOffsetGranularity": { | ||
| "width": 8, |
There was a problem hiding this comment.
@ziga-lunarg this is why the tests were failing, these were returning back 0, 0
|
|
||
| if (fdm_non_zero_offsets && !has_offset_flag) { | ||
| const LogObjectList objlist(cb_state.Handle(), rp_state.Handle(), view_state->Handle()); | ||
| skip |= LogError("VUID-VkFramebufferCreateInfo-renderPass-06502", objlist, |
There was a problem hiding this comment.
new message
vkCmdEndRenderPass2KHR(): pSubpassEndInfo->pNext.pFragmentDensityOffsets[0] is x = 8, y = 8 (non-zero offsets) but pAttachments[0] was not created with VK_IMAGE_CREATE_FRAGMENT_DENSITY_MAP_OFFSET_BIT_QCOM.
(prints the actual offsets now)
| if ((attachment != VK_ATTACHMENT_UNUSED) && (attachment == i) && !has_offset_flag) { | ||
| const LogObjectList objlist(cb_state.Handle(), rp_state.Handle(), view_state->Handle()); | ||
| skip |= | ||
| LogError("VUID-VkSubpassFragmentDensityMapOffsetEndInfoQCOM-pInputAttachments-06506", objlist, offset_count_loc, |
There was a problem hiding this comment.
new message
vkCmdEndRenderPass2KHR(): pSubpassEndInfo->pNext.fragmentDensityOffsetCount is 1 but pInputAttachments[0] (pAttachments[1] VkImageView 0xee647e0000000009) underlying VkImage 0xcb3ee80000000007 was not created with VK_IMAGE_CREATE_FRAGMENT_DENSITY_MAP_OFFSET_BIT_QCOM.
Helps connect which pInputAttachments to which renderpass pAttachments with some handles as well
|
CI Vulkan-ValidationLayers build # 19164 running. |
|
CI Vulkan-ValidationLayers build # 19164 failed. |
Network issue with windows machine, passed internally on Android |
This takes @ziga-lunarg tests (#9506) and improves the error messages for them