tests: Fix RT tests sporadic failures #9538
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 381516. |
|
CI Vulkan-ValidationLayers build # 19207 running. |
| @@ -1870,7 +1870,7 @@ TEST_F(NegativeRayTracing, AccelerationStructuresOverlappingMemory) { | |||
| // of elements in `build_infos` | |||
| // => due to validation code optimisations, not *all* overlaps will be detected, | |||
| // but if there is *at least one*, it will *always+ be detected. | |||
| m_errorMonitor->SetDesiredError("VUID-vkCmdBuildAccelerationStructuresKHR-dstAccelerationStructure-03702", 2); | |||
| m_errorMonitor->SetAllowedFailureMsg("VUID-vkCmdBuildAccelerationStructuresKHR-dstAccelerationStructure-03702"); | |||
There was a problem hiding this comment.
What is the point of this test if everything is SetAllowedFailureMsg
It basically means "sometimes this tests passes, sometimes it falis"
There was a problem hiding this comment.
The emitted errors are un-predictable, it is just the nature of validation: it will depend on the addresses the driver returns, and the order in which memory overlaps are found
There was a problem hiding this comment.
Then just add a comment about the TEST_F saying this for the next person to not go "wait, wtf"
|
CI Vulkan-ValidationLayers build # 19207 failed. |
arno-lunarg
force-pushed
the
arno-rt-test-failures
branch
from
84baa41 to
4b1d4a1
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 381709. |
|
CI Vulkan-ValidationLayers build # 19210 running. |
|
CI Vulkan-ValidationLayers build # 19210 passed. |
No description provided.