Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export facemaps #1614

Closed

Conversation

iuriiiurevich
Copy link

This PR adds the feature of exporting face maps as a mesh attribute by enabling "Face Maps" in the "Geometry" options of the exporter.
Face map names are exported to the current node's extras "facemaps".

"nodes" : [
    {
        "extras" : {
            "facemaps" : [
                "FaceMap"
            ]
        },
        "mesh" : 0,
        "name" : "Cube"
    }
],
"meshes" : [
    {
        "name" : "Cube",
        "primitives" : [
            {
                "attributes" : {
                    "POSITION" : 0,
                    "NORMAL" : 1,
                    "TEXCOORD_0" : 2,
                    "_FACEMAPS" : 3
                },
                "indices" : 4
            }
        ]
    }
],

The topic was discussed here: #1232, #1515

Main idea from here: #1232 (comment)
The original code can be found here: https://github.com/canadaduane/glTF-Blender-IO/tree/export-facemaps-and-vertex-groups

Is it a good idea to merge it into the master branch?

@iuriiiurevich iuriiiurevich changed the title Export facemaps feat: export facemaps Apr 6, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 13, 2022

CLA assistant check
All committers have signed the CLA.

@canadaduane
Copy link

Thanks for all of your work @scurest and @iuriiiurevich. Is there someone who can authorize it being merged in?

@julienduroure
Copy link
Collaborator

A complete refactoring of custom attribute is in progress here: #1676 , and is planned for 3.4
Facemaps will benefit from these refactoring, so this PR will not be merged as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants