Анна Власова, 496: Threads + CQL + CQLex + TwitterStream + ModuleTests #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| numberOfThreads = num; | ||
| } | ||
|
|
||
| private final int myNumber; |
There was a problem hiding this comment.
Сначала пишут все поля, потом все методы, исправьте и в других местах
| while (myNumber != currentThread) { | ||
| Thread.yield(); | ||
| } | ||
| System.out.println("Thread-" + (myNumber + 1) + "\n"); |
There was a problem hiding this comment.
println за вас строчку переводит, не нужно \n добавлять
|
Блокирующую очередь нужно протестировать |
| synchronized List<T> take(int n, long timeout) { | ||
| timeout += System.currentTimeMillis(); | ||
| while ((data.size() < n) && (timeout - System.currentTimeMillis()) > 0) { | ||
| Thread.yield(); |
There was a problem hiding this comment.
Это слишком общая функция, поток будет просыпаться чаще чем нужно.
Для синхронизации лучше использовать блоки synchronized и методы
Object.wait(long timeout) / notifyAll(), или может что-то еще, но потоки должны просыпаться по нашему указанию, а не т любого шороха.
annnvl
changed the title
annnvl
changed the title
annnvl
changed the title
annnvl
changed the title
annnvl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.