Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix LED 1W 3W #2433

Closed
wants to merge 6 commits into from
Closed

Fix LED 1W 3W #2433

wants to merge 6 commits into from

Conversation

Franck78
Copy link

Newer datasheet & small footprint fix

Update the datasheet link to a full english version, hosted on the
Getian's website (the manufacturer).
Fix footprint: set space between pad to 10mm (was ~9.2), just a 0.4mm translation of each pad

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

Replace datasheet link with a newer version
Make the robot checker happy with the grid
Fixe space between pads. It was 9.2mm and datasheet says 10mm.
Prepare for 3d models
@myfreescalewebpage myfreescalewebpage added Enhancement Improves existing footprint in the library Pending reviewer A pull request waiting for a reviewer labels Aug 28, 2020
Or try a least. Arcs are not defined in a way you can choose the two
endpoints precisly.

The other thing is probably a bug from Kicad or an obscure fnctionality.
It sets the libname while exporting a single footprint !
@Franck78 Franck78 changed the title Fix LED 1W 3W 5W Fix LED 1W 3W Aug 28, 2020
@Franck78
Copy link
Author

Travis says

 Violating F5.3

    Courtyard layer requirements
    Courtyard lines are not on 0.01mm grid
     - Arc (0,0) -> (-4.6,-0.4) on layer 'F.CrtYd'
     - Arc (0,0) -> (4.6,0.4) on layer 'F.CrtYd'

I can't do much about that. Arc are not defined with 3 points.
Sorry

@Franck78
Copy link
Author

Franck78 commented Sep 8, 2020

The small difference between the datasheet and the actual design is not worth fixing.

@Franck78 Franck78 closed this Sep 8, 2020
@myfreescalewebpage myfreescalewebpage added Abandoned Original author has stopped working on the PR and removed Pending reviewer A pull request waiting for a reviewer labels Sep 9, 2020
@evanshultz
Copy link
Collaborator

@Franck78
I do believe it's worth fixing. If you want to re-open this PR I can review it. Let's say there is an issue and it's not known that the footprint doesn't match the recommendation in the datasheet. Now it's our problem.

I think you're using a new nightly version of KiCad. Please stick with 5.1.x for all contributions as requested by KLC at http://kicad-pcb.org/libraries/klc/. We will accept contributions newer versions at some point but not yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Enhancement Improves existing footprint in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants