Updating the readme with MacOS install tips. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great help! The code doesn't rely on OpenMP as a hard constraint. The extension loader in TorchDrug uses these lines to detect whether OpenMP is available. If OpenMP is not available, it will fall back to the native parallel of PyTorch. I have no idea what the speed difference is, but PyTorch recommends to use OpenMP for CPU parallel. If you only use Mac for debug purpose, I feel OpenMP is not a must. I am not a Mac user, so please correct me if I am wrong. |
|
Thanks! I agree that OpenMP shouldn't be a hard constraint, however I still needed to take the steps detailed in the PR to even be able to install with on MacOS at all. I'll create a new venv and test if this is still the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a few tips I needed to get this to run on an Intel based MacOS install.
I haven't tested on my M1 machine yet but will update further if any extra steps are needed.