Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* TST, CLN: Remove loss functions from BEM class - Easier to test. - Functions like this should be outside a class, to make it light and prevent technical debt. * BUG, BLD: Add __init__.py file to `bem` module * BLD: Add `bem` imports * BUG: Fix import * ENH: Include `model` module with the BEM implementation * TST: Use fixture for airfoil polars * ENH, TST: `Propeller` class updated with a new `Section` object * TST: Improve test coverage * BLD: Include `pytest-cov` in dev requirements * DOC: Fill docstrings * ENH: Include radii distribution of the sections * DOC, CLN: General changes * ENH: Refactor BEM class * TST: Remove versioneer files from test coverage * ENH: Make homogeneous the usage of degrees and radians The best solution for the moment that I have found is to only convert from deg to rad just before calling a trigonometric method (or approximation, like in the lift coefficient). Like that, it becomes easy to debug (we are used to read degrees, not radians) and the code is "robust'. Ideally there should be a class that defines `Angle` and computes correctly the trigonometric functions. * TST: Fix tests, they were not using correctly the new degrees/radians standard * ENH: Prevent division by zero * TST: Introduce unitary tests for model * Run tests: they do not assert against anything (is a nonlinear equation, that is why I have built a solver in the first place). * Reproduce: these tests check if we are getting the same results as the last time the code was editted. It is a guide to detect if existing bugs alter the result in a meaningful way.
- Loading branch information