Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution: fixes failures when oxi state is unknown #117

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Solution: fixes failures when oxi state is unknown #117

merged 3 commits into from
Mar 13, 2024

Conversation

rkingsbury
Copy link
Member

@rkingsbury rkingsbury commented Mar 13, 2024

Closes #116 by improving handling of unknown oxidation states.

Also bumps pre-commit versions (unrelated)

@rkingsbury rkingsbury added fix Bug Fixes pkg Package and repository health labels Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.28%. Comparing base (02e28bb) to head (934db1f).
Report is 1 commits behind head on main.

Files Patch % Lines
src/pyEQL/solution.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   82.24%   82.28%   +0.03%     
==========================================
  Files          10       10              
  Lines        1453     1456       +3     
  Branches      293      293              
==========================================
+ Hits         1195     1198       +3     
  Misses        220      220              
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury merged commit 11eefc1 into main Mar 13, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug Fixes pkg Package and repository health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Br(None) species - oxidation state error
1 participant