Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging for _adjust_charge_balance #162

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

SuixiongTay
Copy link
Contributor

Refactor logging for _adjust_charge_balance

Description:

  • Edited the log message at line 2298 to remove the redundant log message “Solution is not electroneutral (C.B. = {cb} eq/L).”

Minor changes:

  • Updated the log message at line 2298 to self.logger.info(f"Adjusting {self._cb_species} to compensate.")
  • The separate log message at line 2291 remains as self.logger.info(f"Solution is not electroneutral (C.B. = {cb} eq/L).")

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (65beb17) to head (26afacb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files           9        9           
  Lines        1479     1479           
  Branches      319      319           
=======================================
  Hits         1229     1229           
  Misses        214      214           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuixiongTay
Copy link
Contributor Author

SuixiongTay commented Aug 5, 2024

I realized that I made the push changes directly from my main branch instead of the dev branch. I will be more cautious with this step in future pull requests. Thanks!

@rkingsbury
Copy link
Member

I realized that I made the push changes directly from my main branch instead of the dev branch. I will be more cautious with this step in future pull requests. Thanks!

That's technically OK. The reason to use branches on your fork is that it's often convenient to keep the main branch in your fork in sync with the upstream main branch. That's more difficult to do if you're editing on main branch. But the main important rule is to not push anything to the upstream main branch (and most repos, including this one, will prevent you from doing that anyway).

@rkingsbury
Copy link
Member

Closes #160

@rkingsbury rkingsbury merged commit ff13f30 into KingsburyLab:main Aug 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants