updated python-version line 48 and removed dev

[abhardwaj73]

Summary

Major changes:

• fix 1: updated python-version line 48 and removed dev

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (1c57f26) to head (8c171cc).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files           9        9           
  Lines        1479     1479           
  Branches      319      319           
=======================================
  Hits         1229     1229           
  Misses        214      214           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rkingsbury]

Thanks @abhardwaj73 ! This initially failed with the error below:

The workflow is not valid. .github/workflows/post-process.yml (Line: 48, Col: 29): Unrecognized named-value: 'matrix'. Located at position 1 within expression: matrix.version.python

The solution was non-trivial, but I think I fixed this in #166 . Because I didn't fully understand what the problem was and the tests could only run after I merged your PRs, I decided best to just try to fix myself. TL;DR - the exclude part of the workflow (which skips certain combinations of conditions in the text matrix) has a strange syntax when our matrix uses nested keys.

[abhardwaj73]

Thanks @rkingsbury

[rkingsbury]

OK, it's actually working! The first post-process run failed, but it failed because it's doing it's job. Using the lowest-direct dependency resolution strategy, it tried to install iapws==1.0.0 (whereas the latest version is 1.5 something). That failed with the following

Run python -m pip install --upgrade pip
Requirement already satisfied: pip in /opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages (24.2)
Collecting uv
  Downloading uv-0.2.34-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (36 kB)
Downloading uv-0.2.34-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (12.1 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 12.1/12.1 MB 98.5 MB/s eta 0:00:00
Installing collected packages: uv
Successfully installed uv-0.2.34
error: Failed to download and build `iapws==1.0.0`
  Caused by: Failed to build: `iapws==1.0.0`
  Caused by: Build backend failed to determine extra requires with `build_wheel()` with exit status: 1
--- stdout:

--- stderr:
error: package directory 'gpl' does not exist
---
Error: Process completed with exit code 2.

Which I was able to reproduce locally, and it turned out to be a problem with that package version. See the last line.

(skagit2) ryan@AND-PF4F2QCJ:~/mambaforge/envs/skagit/code$ uv pip install iapws==1.0.0
⠼ iapws==1.0.0                                                                                                             error: Failed to download and build `iapws==1.0.0`
  Caused by: Failed to build: `iapws==1.0.0`
  Caused by: Build backend failed to determine extra requires with `build_wheel()` with exit status: 1
--- stdout:

--- stderr:
error: package directory 'gpl' does not exist
---
(skagit2) ryan@AND-PF4F2QCJ:~/mambaforge/envs/skagit/code$ pip install iapws==1.0.0
Defaulting to user installation because normal site-packages is not writeable
Collecting iapws==1.0.0
  Downloading iapws-1.0.0.tar.gz (37 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      error: package directory 'gpl' does not exist
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

v1.0.1 works, so now I can update the dependencies for pyEQL to require at least that version.