Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify pre-commit; run on all files #191

Merged
merged 3 commits into from
Sep 25, 2024
Merged

modify pre-commit; run on all files #191

merged 3 commits into from
Sep 25, 2024

Conversation

rkingsbury
Copy link
Member

Minor changes to the pre-commit configuration to make handling .json files easier and to separate linting from formatting in ruff. Note that Jupyter notebooks will now be formatted but not subjected to linting.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.65%. Comparing base (1a70aa0) to head (0eaacb6).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/pyEQL/solution.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   81.65%   81.65%           
=======================================
  Files           9        9           
  Lines        1494     1494           
  Branches      326      326           
=======================================
  Hits         1220     1220           
  Misses        227      227           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury added housekeeping pkg Package and repository health labels Sep 25, 2024
@rkingsbury rkingsbury merged commit 2ff92ef into main Sep 25, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping pkg Package and repository health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant