-
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add additional handling of symbolic links (#1)
This PR contains some breaking changes. Some special handling is required when it comes to directory symbolic links. On Windows, `ReadDirectoryChangesExW` will not read the subtree of a directory symbolic link despite `bWatchSubtree` set to `true`. On Linux, the current build didn't take symbolic links into account. Now, the watcher can watch directory symbolic links. ## Changes - Attempting to construct a `FileSystemWatcher` with a relative path that leads to outside of the game directory will now throw an error. - `FileSystemWatcher.GetPath()` will no longer be guaranteed to have a trailing separator. - Added `FileSystemWatcher.WatchDirectoryLinks`, which toggles whether to watch subdirectory symbolic links. By default, this is set to `true`. - `FileSystemWatcher.RetryInterval` is now deprecated and does nothing.
- Loading branch information
Showing
27 changed files
with
2,701 additions
and
1,984 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "extension/tests/googletests"] | ||
path = extension/tests/googletests | ||
url = https://github.com/google/googletest |
Oops, something went wrong.