add bambu; #132
Merged
add bambu; #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 23.60% 23.23% -0.38%
==========================================
Files 49 50 +1
Lines 2699 2742 +43
==========================================
Hits 637 637
- Misses 2062 2105 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jess Frazelle <[email protected]>
paultag
requested changes
Oct 17, 2024
src/bin/machine-api/cmd_serve.rs
Outdated
| @@ -125,6 +125,9 @@ pub async fn main(_cli: &Cli, cfg: &Config, bind: &str) -> Result<()> { | |||
| AnyMachine::Moonraker(moonraker) => { | |||
| spawn_metrics(&mut registry, key, moonraker.get_temperature_sensors()).await?; | |||
| } | |||
| AnyMachine::BambuX1Carbon(bambu) => { | |||
| spawn_metrics(&mut registry, key, bambu.get_temperature_sensors()).await?; | |||
There was a problem hiding this comment.
we discovered this is currently broken because this will race the discovery loop and not spawn metrics for printers discovered after the time of this function call. we need to wire this in deeper
Signed-off-by: Jess Frazelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.