Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.... I think this is wrong and leaking to a leak #96

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

paultag
Copy link
Collaborator

@paultag paultag commented Sep 10, 2024

needs a test -- thanks to @jessfraz for the report

needs a test -- thanks to @jessfraz for the report
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 25.69%. Comparing base (4c876cf) to head (4f19f83).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/bambu/discover.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   25.70%   25.69%   -0.02%     
==========================================
  Files          46       46              
  Lines        2474     2475       +1     
==========================================
  Hits          636      636              
- Misses       1838     1839       +1     
Flag Coverage Δ
unittests 25.69% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paultag paultag merged commit 816279e into main Sep 10, 2024
5 of 6 checks passed
@paultag paultag deleted the paultag/check-key branch September 10, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant