Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tag as top level part 2 #2773

Merged
merged 22 commits into from
Jun 25, 2024
Merged

tag as top level part 2 #2773

merged 22 commits into from
Jun 25, 2024

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Jun 24, 2024 •
edited
Loading

If you run "format" on your files your code will update!

follow on from #2769

ill pull thru the format stuff to the cli after merge, but everything is backwards compatible

  • add stdlib always parsing TagDeclarators
  • add code mods to recast so we can easily update everyone's files
  • make all js code mods make the new syntax

What will come in part 3:

  • migrate all tests and shit to new syntax
  • after a few releases remove backwards compatibility

@jessfraz
updates
421d9b3 
Signed-off-by: Jess Frazelle <[email protected]>
@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Jun 24, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel Vercel
Copy link

vercel bot commented Jun 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jun 25, 2024 4:48am

@jessfraz
updates
5e30061 
Signed-off-by: Jess Frazelle <[email protected]>
@jessfraz
fmt
91fee91 
Signed-off-by: Jess Frazelle <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jun 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.03593% with 30 lines in your changes missing coverage. Please review.

Project coverage is 86.39%. Comparing base (496398d) to head (ff92137).
Report is 2 commits behind head on main.

❗ Current head ff92137 differs from pull request most recent head 9880d17

Please upload reports for the commit 9880d17 to get more accurate results.

Files Patch % Lines
src/wasm-lib/kcl/src/parser/parser_impl.rs 63.41% 30 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
- Coverage   86.50%   86.39%   -0.12%     
==========================================
  Files          61       61              
  Lines       23466    23579     +113     
==========================================
+ Hits        20299    20370      +71     
- Misses       3167     3209      +42
Flag Coverage Δ
wasm-lib 86.39% <82.03%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz
updates
9b353b0 
Signed-off-by: Jess Frazelle <[email protected]>
@jessfraz
unit tests pass
a6b52a6 
Signed-off-by: Jess Frazelle <[email protected]>
@jessfraz
playwright
1049d3e 
Signed-off-by: Jess Frazelle <[email protected]>
@jessfraz
updates
936336b 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz
format
9844fb2 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz jessfraz mentioned this pull request Jun 25, 2024
Closed
@jessfraz
format
e070e14 
Signed-off-by: Jess Frazelle <[email protected]>
@jessfraz
updates
4bb1c45 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz
more literals gone
b3ea052 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz
updates
03a0e10 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz
fixes
803bb78 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz
remove console log
30b11ee 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz
fixes
64ec1df 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz jessfraz enabled auto-merge (squash) June 25, 2024 03:06
@jessfraz jessfraz disabled auto-merge June 25, 2024 03:07
@jessfraz jessfraz enabled auto-merge (squash) June 25, 2024 03:08
@jessfraz
remove only
ff92137 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz
fix some recast shit
da25fd6 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz
updates
aa5b342 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz
last
9880d17 
Signed-off-by: Jess Frazelle <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@jessfraz jessfraz disabled auto-merge June 25, 2024 05:38
@jessfraz jessfraz merged commit da6cd5c into main Jun 25, 2024
17 of 22 checks passed
@jessfraz jessfraz deleted the tag-as-top-level branch June 25, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jessfraz