Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v0.22.7 #2826

Merged
merged 12 commits into from
Jul 1, 2024
Merged

Cut release v0.22.7 #2826

merged 12 commits into from
Jul 1, 2024

Conversation

Irev-Dev
Copy link
Collaborator

@Irev-Dev Irev-Dev commented Jun 27, 2024

What's Changed

Most importantly the syntax for tags is now $myTag to declare a tag and myTag to then use it later. If you format your code via Alt+Shift+F or the three dot menu on the code panel it will fix this for you. We will keep backwards compatibility with string tags for a few releases but you should update your code now.

The nice thing about this is now the code editor autocompletes tag names for you and now you can get better errors when you abuse tags.

So for example this code:

const sketch001 = startSketchOn('XZ')
  |> startProfileAt([65.87, 230.28], %)
  |> line([248.25, -79.48], %)
  |> line([-74.04, -283.09], %, 'myTag')
  |> line([-192.72, 235.18], %)
  |> lineTo([profileStartX(%), profileStartY(%)], %)
  |> close(%)
  |> extrude(100, %)

const sketch002 = startSketchOn(sketch001, 'myTag')
  |> startProfileAt([185.8, 131.39], %)
  |> line([62.76, -12.99], %)
  |> line([-27.05, -47.61], %)
  |> line([-43.65, 9.37], %)
  |> lineTo([profileStartX(%), profileStartY(%)], %)
  |> close(%)

Becomes:

const sketch001 = startSketchOn('XZ')
  |> startProfileAt([65.87, 230.28], %)
  |> line([248.25, -79.48], %)
  |> line([-74.04, -283.09], %, $myTag)
  |> line([-192.72, 235.18], %)
  |> lineTo([profileStartX(%), profileStartY(%)], %)
  |> close(%)
  |> extrude(100, %)

const sketch002 = startSketchOn(sketch001, myTag)
  |> startProfileAt([185.8, 131.39], %)
  |> line([62.76, -12.99], %)
  |> line([-27.05, -47.61], %)
  |> line([-43.65, 9.37], %)
  |> lineTo([profileStartX(%), profileStartY(%)], %)
  |> close(%)

Full Changelog: v0.22.6...v0.22.7

Copy link

qa-wolf bot commented Jun 27, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jul 1, 2024 7:49pm

@pierremtb
Copy link
Collaborator

Testing on macOS:

  • sign in
  • open project
  • close project
  • create project
  • create sketch
  • create rectangle
  • create var
  • resize with var
  • extrude with var
  • export to STL: failed
  • export to OBJ: failed

Issue created #2840

@jessfraz
Copy link
Contributor

jessfraz commented Jul 1, 2024

between ubuntu and macos they playwright arent failing on the same tests so i think we are okay.

will try locally
ubuntu:

[Google Chrome] › flow-tests.spec.ts:235:7 › Testing Camera Movement › Can moving camera 

macos:

[webkit] › flow-tests.spec.ts:397:7 › Testing Camera Movement › Zoom should be consistent when exiting or entering sketches 
    [webkit] › flow-tests.spec.ts:5826:9 › Testing segment overlays › Testing deleting a segment › all segment types 
    [webkit] › flow-tests.spec.ts:6350:5 › Basic default modeling and sketch hotkeys work 

@jessfraz
Copy link
Contributor

jessfraz commented Jul 1, 2024

the tests work locally for me and i pushed a fix to one to make more reliable

@pierremtb
Copy link
Collaborator

Did my usual test round on macOS, looks good. Will try Windows in a minute

@pierremtb
Copy link
Collaborator

Windows looking good too

Copy link
Collaborator

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local tests on Windows and macOS look good!

@jessfraz jessfraz merged commit 8f13810 into main Jul 1, 2024
13 of 15 checks passed
@jessfraz jessfraz deleted the cut-release-v0.22.7 branch July 1, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants