Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to create and open URLs to duplicate files #4166

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

Add ability to create and open URLs to duplicate files #4166

wants to merge 54 commits into from

Conversation

franknoirot
Copy link
Collaborator

@franknoirot franknoirot commented Oct 15, 2024 •
edited
Loading

Still a WIP until this list is completed:

  • Add a command to create a share URL
  • Add a menu item that invoke that command
  • Add logic to honor that URL on the website
  • Add logic to honor that URL on the desktop app
    • Need to fix deep linking to actually pass through the query params

franknoirot and others added 30 commits October 4, 2024 16:16
@franknoirot
Rename homeMachine and accessories to projectsMachine
401dcf8
@franknoirot
Separate out /home route from projectsMachine
5822321
@franknoirot
Add logic to navigate out from deleted or renamed project
5bd8904
@franknoirot
Show a warning in the command palette for deleting a project
049e487
@franknoirot
Make it navigate when you create a project
d7fe827
@franknoirot
Update "New project" button to use command bar flow
4f06524 
Closes #2585
@franknoirot
More explicit warning message text
5d8f3f9
@franknoirot
Merge branch 'main' into franknoirot/4088/decouple-homeMachine
f496d94
@franknoirot
Make projects watching code not run in web
fe6d1f8
@franknoirot
Tests first version: nested loops
bfccb79
@franknoirot
Tests second version: flattened
238163d
@franknoirot
Remove console logs
3fc707a
@franknoirot
Fix tsc
f163870
@franknoirot
@jtran feedback, use the type guard util
8ab24ce
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest)
d1be6d7
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest)
7545b61
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest)
3d2e487
@franknoirot
Fix tests that relied on one-click, no-navigation project creation
f0136a5
@franknoirot
Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest)"
75e3f84 
This reverts commit 7545b61.
@franknoirot
Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest)"
e22a9ed 
This reverts commit 3d2e487.
@franknoirot
Add a mask to the state indicator to client-side scale test
372f2ee
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest)
1f515b7
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest)
9378d98
@franknoirot
Merge branch 'main' into franknoirot/4088/decouple-homeMachine
80e32b3
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest)
48380be
@franknoirot
Merge branch 'main' into franknoirot/4088/decouple-homeMachine
f4ecd16
@franknoirot
Fix lint
14eeafb
@franknoirot
Fix tsc
403cee5
@franknoirot
Add menu item to share link to file
30a24c8
@franknoirot
Forward query params while redirecting to /home or /file
8141103
franknoirot and others added 15 commits October 8, 2024 15:32
@franknoirot
Merge branch 'franknoirot/4088/decouple-homeMachine' into franknoirot…
524fcb0 
…/4088/create-file-url
@franknoirot
Merge branch 'main' into franknoirot/update-download-progress
02b249b
@franknoirot
De-flake another text that could be thrown off by toast-based selectors
746ebf8
@franknoirot
FMT
15bedd5
@franknoirot
Dumb test error because I was rushing
1ce3d8c
@franknoirot
Merge branch 'franknoirot/4088/decouple-homeMachine' into franknoirot…
c882e34 
…/4088/create-file-url
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest)
a2330a0
@franknoirot
Merge branch 'main' into franknoirot/4088/decouple-homeMachine
698ce67
@franknoirot
Ahhh more flaky toasts, they're everywhere!
4748c2d
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest)
36d49b1
@franknoirot
Side quest: Only register commands once, power their disabled status …
96b0624 
…while selecting commands via optional actor
@franknoirot
Get query-triggered command working in browser too
d58a147
@franknoirot
Merge branch 'main' into franknoirot/4088/decouple-homeMachine
1e5954e
@franknoirot
Merge branch 'main' into franknoirot/4088/decouple-homeMachine
b84d595
@franknoirot
Merge branch 'franknoirot/4088/decouple-homeMachine' into franknoirot…
bb67a9e 
…/4088/create-file-url
@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Oct 15, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Oct 19, 2024 4:28am

Base automatically changed from franknoirot/4088/decouple-homeMachine to main October 28, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franknoirot @lf94