Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Pass through sweep.subType in expandSweep #4383

Merged
merged 32 commits into from
Nov 12, 2024
Merged
Changes from 2 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
65f887d
Internal: Pass through `sweep.subType` in `expandSweep`
franknoirot Nov 4, 2024
3157fa9
Merge branch 'main' into franknoirot/adhoc/fix-expandSweep
lf94 Nov 5, 2024
76b6924
A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores)
github-actions[bot] Nov 5, 2024
c449e09
Merge branch 'main' into franknoirot/adhoc/fix-expandSweep
franknoirot Nov 5, 2024
2fbea57
A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores)
github-actions[bot] Nov 5, 2024
30e2cb8
Merge branch 'main' into franknoirot/adhoc/fix-expandSweep
franknoirot Nov 5, 2024
834562c
implement a simple startSketchOn / offsetPlane lint rule (#4384)
paultag Nov 5, 2024
0ec099b
Bump kittycad-modeling-cmds from 0.2.71 to 0.2.72 in /src/wasm-lib (#…
dependabot[bot] Nov 5, 2024
37e3af9
Bump google-github-actions/upload-cloud-storage from 2.2.0 to 2.2.1 (…
dependabot[bot] Nov 5, 2024
3afffd4
Internal fix: make `expandPath` not assume path has associated sweep …
franknoirot Nov 6, 2024
32b5b84
Bump happy-dom from 14.12.3 to 15.10.1 (#4404)
dependabot[bot] Nov 6, 2024
0ac8ca9
Bump @electron-forge/maker-zip from 7.4.0 to 7.5.0 (#4394)
dependabot[bot] Nov 6, 2024
fddac3a
Bump uuid from 9.0.1 to 11.0.2 (#4393)
dependabot[bot] Nov 6, 2024
2fb9ac9
Bump validator from 0.18.1 to 0.19.0 in /src/wasm-lib (#4396)
dependabot[bot] Nov 6, 2024
cf38510
Bump insta from 1.41.0 to 1.41.1 in /src/wasm-lib (#4400)
dependabot[bot] Nov 6, 2024
436247f
Bump pyo3 from 0.22.5 to 0.22.6 in /src/wasm-lib (#4398)
dependabot[bot] Nov 6, 2024
56142d3
Bump thiserror from 1.0.65 to 2.0.0 in /src/wasm-lib (#4397)
dependabot[bot] Nov 6, 2024
7079ff9
Bump url from 2.5.2 to 2.5.3 in /src/wasm-lib (#4399)
dependabot[bot] Nov 6, 2024
dbe114b
Bump @types/ws from 8.5.12 to 8.5.13 (#4395)
dependabot[bot] Nov 6, 2024
e7f358a
File tree to act more like VS Code's file tree (#4392)
lf94 Nov 6, 2024
ea4d88f
Fixing directory/file selection logic to deselect folders properly an…
nadr0 Nov 6, 2024
189b0a6
Bump happy-dom from 15.10.1 to 15.10.2 (#4409)
dependabot[bot] Nov 7, 2024
ec15ea2
Change Dependabot PR frequency to weekly (#4424)
jtran Nov 7, 2024
505f428
Update insta snapshots (#4423)
adamchalmers Nov 7, 2024
12b82a5
Fix KCL source ranges to know which source file they point to (#4418)
jtran Nov 7, 2024
1a8f1e3
Bump anyhow from 1.0.92 to 1.0.93 in /src/wasm-lib (#4417)
dependabot[bot] Nov 7, 2024
6d2c486
Cut release v0.26.3 (#4427)
franknoirot Nov 7, 2024
e48df49
Bump image from 0.25.3 to 0.25.5 in /src/wasm-lib (#4416)
dependabot[bot] Nov 7, 2024
979ea43
Nadro/3799/perf (#4145)
nadr0 Nov 7, 2024
7ef3d70
Merge branch 'main' into franknoirot/adhoc/fix-expandSweep
franknoirot Nov 7, 2024
77dd649
A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest-8-cores)
github-actions[bot] Nov 7, 2024
ffe3e3e
Merge branch 'main' into franknoirot/adhoc/fix-expandSweep
franknoirot Nov 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lang/std/artifactGraph.ts
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ export function expandSweep(
if (err(path)) return path
return {
type: 'sweep',
subType: 'extrusion',
subType: sweep.subType,
surfaces: Array.from(surfs.values()),
edges: Array.from(edges.values()),
path,
Expand Down
Loading