Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo feature resolution by using cargo workspace resolver v2 #4445

Closed
wants to merge 1 commit into from

Conversation

jtran
Copy link
Collaborator

@jtran jtran commented Nov 8, 2024

No description provided.

Copy link

qa-wolf bot commented Nov 8, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Nov 8, 2024 8:26pm

@jtran jtran changed the title Fix cargo publish by using cargo workspace resolver v2 Fix cargo feature resolution by using cargo workspace resolver v2 Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (062fae1) to head (612b573).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4445   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files          80       80           
  Lines       28361    28361           
=======================================
  Hits        24472    24472           
  Misses       3889     3889           
Flag Coverage Δ
wasm-lib 86.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtran
Copy link
Collaborator Author

jtran commented Nov 9, 2024

We found another fix for our issue. This change can wait until the 2024 edition of Rust.

@jtran jtran closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant