Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Deflake project settings override on desktop (#4370)" #4450

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

lf94
Copy link
Contributor

@lf94 lf94 commented Nov 8, 2024

This reverts commit ad1cd56.

Copy link

qa-wolf bot commented Nov 8, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Nov 8, 2024 10:09pm

Copy link
Collaborator

@nadr0 nadr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reverting this Lee!

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lf94

@nadr0 nadr0 merged commit b11040c into main Nov 8, 2024
28 checks passed
@nadr0 nadr0 deleted the fix-it branch November 8, 2024 22:16
@franknoirot franknoirot mentioned this pull request Nov 8, 2024
lf94 added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants