Nadro/adhoc/center rectangle #4480
Conversation
…r rectangle expressions
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
Oh wtf my VS Code extension didn't save the comments, so annoying |
| : 'none', | ||
| }, | ||
| }), | ||
| icon: 'arc', |
There was a problem hiding this comment.
(comment): This looks like you might have been testing out if it had any effect, which it doesn't. So maybe we need a TODO to make the dropdown items support icons; I can make a Center Rectangle icon coming up soon.
| ;((pipeExpression.body[1] as CallExpression) | ||
| .arguments[0] as ArrayExpression) = createArrayExpression([ |
There was a problem hiding this comment.
(nit): Should this make use of your new cool type narrowing functions as well?
There was a problem hiding this comment.
(comment): I didn't know about this syntax, super cool
There was a problem hiding this comment.
(comment): Kurt's done some cool work to make this stuff less boilerplate-filled, and I'd love your ideas as you touch code like this on how to take it further, because it still feels repetitive and "getting your hands dirty", na mean?
| @@ -215,6 +217,7 @@ export function Toolbar({ | |||
| } | |||
| const itemConfig = maybeIconConfig | |||
|
|
|||
| // A single button | |||
There was a problem hiding this comment.
(comment):
// A single button
...followed by like 40 lines of JSX lol
closes #4402
Implements
Center Rectanglein the toolbar and updated it with the new stateRectanglebut forCenter RectanglecreateLiteraldefinition since it didn't actually use the typeLiteralValueGotchas
startProfileAtbut once they click into the second state for dragging the width and height it will be corrected since there is dimension to the box. It effectively says the startProfile at is the center with width/height of 0.Future improvements