Fix to not have unneeded console errors #4482
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice, but what happens when we do need the stack trace? new Reason(new Error().stack) ? |
|
You would not use |
| } else if (!err(sg)) { | ||
| processedMemory[key] = sg.paths.map(({ __geoMeta, ...rest }: Path) => { | ||
| } else if (!(sk instanceof Reason)) { | ||
| processedMemory[key] = sk.paths.map(({ __geoMeta, ...rest }: Path) => { |
There was a problem hiding this comment.
If you can assure me this is actually not an error, I'll approve this to add to our toolbox.
There was a problem hiding this comment.
What do you mean? The return type of sketchFromKclValueOptional() cannot return an error.
There was a problem hiding this comment.
The point of this component is to display everything in memory in the UI. The only reason it checks for a sketch is so that it can be displayed differently from other types of values.
jtran
force-pushed
the
jtran/reduce-console-noise
branch
from
2c21297
to
4affd77
Compare
We were logging errors when there were no actual problems. The variables pane is one place, but there are others.
This adds an optional variant of a function that was generating errors.
This also adds a
Reasonclass that can be used in this pattern where you don't want to duplicate logic, but you also don't want to generate an error only to throw it away in the caller.The root cause is the
console.error()in ourerr()function.Slack