Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vercel edge functions #133

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Use vercel edge functions #133

merged 4 commits into from
Apr 4, 2024

Conversation

iterion
Copy link
Contributor

@iterion iterion commented Apr 4, 2024

I think this is all that's needed, lmk if it doesn't make sense.

@iterion iterion requested a review from franknoirot April 4, 2024 12:56
Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
text-to-cad-ui ✅ Ready (Inspect) Visit Preview Apr 4, 2024 1:29pm

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iterion I'm not convinced that this will ensure that all pages and endpoints use the edge runtime based on the way that SvelteKit routes are defined. I think a more comprehensive approach would be to install the Vercel deployment adapter for SvelteKit and configure runtime: 'edge' there (here's another demo).

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM and CI is happy

@franknoirot franknoirot merged commit 8360c91 into main Apr 4, 2024
3 checks passed
@franknoirot franknoirot deleted the add-page-edge-rendering branch April 4, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants