Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max-height style to allow long prompt text to scroll and not escape viewport #149

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

edwardsharp
Copy link
Contributor

hi! cool product! was playing around and noticed some bugginess with the prompt text input field where if there's a long prompt the textarea will not scroll and it will keep expanding until it goes off the top edge of the viewport. i was able to run this locally to test (had to hack out some stuff to get the prompt textarea to render); see before & after screenshots.

one other thing, fwiw: i didn't understand is why the <textarea /> has spellcheck="false"? i'm the worst at spelling so not having red squiggles wouldn't be my preference. there's probably a reason for it, tho; so i didn't change it.

also looking forward to the resolve from #138 because it was a little confusing at first that i couldn't edit the prompt again. it wasn't very difficult to realize i just needed to create a new prompt and copy/paste my old one in to keep editing. oh and deleting prompts would be cool, too. 🤷

before

Text-to-CAD heading gets pushed off screen and so do the context of the prompt text; the text is not able to scroll.

before Screenshot 2024-08-20 at 11 17 48 AM

after

heading stays, text can scroll (see scrollbar 😎)

after Screenshot 2024-08-20 at 11 24 37 AM

Copy link

vercel bot commented Aug 20, 2024

@edwardsharp is attempting to deploy a commit to the Zoo Team on Vercel.

A member of the Team first needs to authorize it.

@franknoirot
Copy link
Collaborator

Wow hey @edwardsharp I apologize I didn't see your PR because I've been heads down on modeling-app! This is on my radar now

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@franknoirot franknoirot merged commit baa66b5 into KittyCAD:main Oct 11, 2024
2 of 3 checks passed
@edwardsharp edwardsharp deleted the e-add-textarea-max-height branch October 14, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants