Disable curl's Expect header #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones6
changed the title
ianpartridge
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This relates to #293. If we use Kitura-net's ClientRequest to send a request to a Kitura server (using either Kitura-net or Kitura-NIO) with a payload over a certain threshold, curl will stall for a second because the server does not acknowledge the
Expect: 100-continueheader that it sends. It still works, but it adds 1 second to the request latency.We can avoid this by setting an empty
Expectheader, which disables this feature of curl (it sends the entire request in one shot).This is particularly beneficial to the Kitura tests, which otherwise take a second each to complete.
Motivation and Context
How Has This Been Tested?
Checklist: