-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-introduce shutdown fix and bump to async-http-client 1.2.0 #90
base: master
Are you sure you want to change the base?
Conversation
Danny Sung seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@mbarnach There was some issue when you introduced this last time where other packages weren't compiling/running correctly. I don't remember why. But I'm reintroducing this and will tag it as a separate version so hopefully we'll be able to control it with versioning until the underlying issue is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@mbarnach there's weird compile issues and docker rate limiting... This might take me a while. |
… org - Update CircuitBreaker dependency to version pointing to Kitura org - Add some debug printsin TestServer - Tweak unit test testCircuitBreakFailure() - RestRequest now attempts to shutdown immediately after request and before completion handler - Disable test: testEventLoopGroup; it may(?) not still be relevant
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
No description provided.