Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(imagereslicemapper): be less sensitive for "snapping" to nearest … #3159

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

finetjul
Copy link
Member

…orthogonal axis

When using the vtkImageResliceMapper in conjunction with the ResliceCursorWidget(RWC), there was a case when the RCW lines were displayed partly being the slice when the slice plane was being snapped to the nearest orthogonal axis.

Context

When rotating the ResliceCursorWidget near an orthogonal axis, the RCW line was being displayed partly in front of the slice and partly behind the slice. This is because the slice was snapped to the nearest orthogonal axis.

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js: master
    • OS: Windows 11
    • Browser: Chrome

…orthogonal axis

When using the vtkImageResliceMapper in conjunction with the ResliceCursorWidget(RWC), there was a
case when the RCW lines were displayed partly being the slice when the slice plane was being snapped
to the nearest orthogonal axis.
@finetjul finetjul merged commit 04ece80 into Kitware:beta Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant