Skip to content

Commit

Permalink
fix(python): use print for the startup message, not log.critical
Browse files Browse the repository at this point in the history
logging.critical is used to convey serious error situations. Some services set
alerts on critical messages, so the use of log.critical for startup confuses
them.
  • Loading branch information
yasushi-saito committed Dec 27, 2021
1 parent 99d8307 commit bee2f52
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/src/wslink/backends/aiohttp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

async def _on_startup(app):
# Emit an expected log message so launcher.py knows we've started up.
logging.critical("wslink: Starting factory")
print("wslink: Starting factory")
# We've seen some issues with stdout buffering - be conservative.
sys.stdout.flush()

Expand Down

0 comments on commit bee2f52

Please sign in to comment.