Multiple modules support #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enable building multiple VTK modules from the same source tree even if they do not depend on each other!
VTK_MODULE_SOURCE_DIR is used at different points and depending on the CMake command that use it the base directory may be different. Making it a full path from CMAKE_SOURCE_DIR helps to have a consistent behavior. Increase minimum CMake required version to 3.20 for cmake_path support!
Old condition used to be always true due to variable
${_vtk_build_depend_package}_DIR being defined by a previous find_package
call to NOTFOUND. This happens when we have multiple modules with internal
dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements that will help us with Slicer as a library project!
@jcfr