feat: Reorder flow to avoid concurrency failures

KminekMatej · Sep 6, 2024 · ff03b39 · ff03b39
1 parent 08daa08
commit ff03b39
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/module/attendance/manager/AttendanceManager.php b/app/module/attendance/manager/AttendanceManager.php
@@ -301,9 +301,9 @@ public function create(array $data, ?int $resourceId = null): Attendance
             $this->responder->E4005_OBJECT_NOT_FOUND(Event::MODULE, $data["eventId"]);
         }
 
-        $existingAttendance = $this->getByEventUserId($data["eventId"], $data["userId"]);
-
         $this->allowCreate($data); //allowCreate checks right for both creating and updating already created attendance
+
+        $existingAttendance = $this->getByEventUserId($data["eventId"], $data["userId"]);
         if (!$existingAttendance instanceof Attendance) {
             $created = $this->createByArray($data);
             if ($created && isset($data["preStatusId"])) {