Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cerulean Sonar ROV Locator #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NickNothom
Copy link

The Cerulean Sonar ROV Locator is an underwater localization system.

This commit adds our "RTH" message

@coveralls
Copy link

coveralls commented Jun 18, 2020

Coverage Status

Coverage increased (+0.006%) to 98.083% when pulling bc49070 on NickNothom:master into 4527cf4 on Knio:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 98.083% when pulling 1d060f0 on NickNothom:master into 4527cf4 on Knio:master.

@Knio
Copy link
Owner

Knio commented Jun 22, 2020

Hi, thanks for the addition. Can you provide a sample sentence and add it to a unit test? Something like https://github.com/Knio/pynmea2/blob/master/test/test_rdi.py would be enough.

@NickNothom
Copy link
Author

@Knio Let me know if that is sufficient

@NickNothom
Copy link
Author

@Knio Please let me know if I need to do anything else to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants