Feature/#49 node factories with common configs #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarjerzyk
reviewed
Nov 22, 2019
handler/core/src/main/java/io/knotx/fragments/task/factory/DefaultTaskFactory.java
Outdated
Show resolved
Hide resolved
handler/core/src/test/java/io/knotx/fragments/handler/FragmentsHandlerTest.java
Show resolved
Hide resolved
tomaszmichalak
changed the base branch from
feature/#49-node-factories
to
master
malaskowski
reviewed
Nov 25, 2019
handler/core/src/main/java/io/knotx/fragments/handler/FragmentsHandler.java
Outdated
Show resolved
Hide resolved
handler/core/src/main/java/io/knotx/fragments/handler/FragmentsHandler.java
Outdated
Show resolved
Hide resolved
handler/core/src/main/java/io/knotx/fragments/handler/FragmentsHandler.java
Outdated
Show resolved
Hide resolved
handler/core/src/main/java/io/knotx/fragments/task/exception/NodeFactoryNotFoundException.java
Outdated
Show resolved
Hide resolved
handler/core/src/main/java/io/knotx/fragments/task/factory/TaskOptions.java
Outdated
Show resolved
Hide resolved
handler/core/src/main/java/io/knotx/fragments/task/factory/node/NodeFactory.java
Show resolved
Hide resolved
handler/core/src/main/java/io/knotx/fragments/task/factory/node/NodeFactoryOptions.java
Show resolved
Hide resolved
...er/core/src/main/java/io/knotx/fragments/task/factory/node/subtasks/SubtasksNodeFactory.java
Outdated
Show resolved
Hide resolved
| import java.util.function.Consumer; | ||
| import org.junit.jupiter.api.Assertions; | ||
|
|
||
| public class HoconLoader { |
There was a problem hiding this comment.
Consider moving to knotx-junit5.
Co-Authored-By: Maciej Laskowski <[email protected]>
Co-Authored-By: Maciej Laskowski <[email protected]>
…ub.com:Knotx/knotx-fragments into feature/#49-node-factories-with-common-configs
6 tasks
tomaszmichalak
deleted the
feature/#49-node-factories-with-common-configs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It introduces task & graph node factories. It is connected with issue #49.
Motivation and Context
The task & node factories allow customizing fragments' processing according to the project's needs. From now tasks' definitions can be loaded outside Knot.x. Moreover, we can add the custom node factory defining node options more dynamically.
Upgrade notes (if appropriate)
Described in Knotx/knotx-stack#62.
Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.