Add support for Mercator Ikuu Combination Sensor SSWM-PIR-ZB #7918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Aug 30, 2024
| model: 'SSWMPIR-ZB', | ||
| vendor: 'Mercator Ikuü', | ||
| description: 'Combination Sensor', | ||
| fromZigbee: [fz.occupancy, fz.temperature, fz.humidity, fz.illuminance, fz.on_off, tuya.fz.datapoints], |
There was a problem hiding this comment.
Suggested change
| fromZigbee: [fz.occupancy, fz.temperature, fz.humidity, fz.illuminance, fz.on_off, tuya.fz.datapoints], | |
| fromZigbee: [tuya.fz.datapoints], |
Please test if it also works with just this
Koenkk
reviewed
Aug 30, 2024
| configure: async (device, coordinatorEndpoint, logger) => { | ||
| const endpoint = device.getEndpoint(1); | ||
| await reporting.bind(endpoint, coordinatorEndpoint, ['genBasic', 'genOta', 'genTime', 'genGroups', 'genScenes']); | ||
| await reporting.bind(endpoint, coordinatorEndpoint, ['genIdentify', 'manuSpecificTuya']); |
There was a problem hiding this comment.
Are these binds really needed? Can you check after removing them and re-pairing the device, the device still works?
Koenkk
reviewed
Aug 30, 2024
| tuyaDatapoints: [ | ||
| [1, 'temperature', tuya.valueConverter.divideBy10], | ||
| [2, 'humidity', tuya.valueConverter.raw], | ||
| //[10, ], |
There was a problem hiding this comment.
Please remove all //[10, ],, it doesn't add any value
Koenkk
reviewed
Aug 30, 2024
| //[102, ], | ||
| //[103, ], | ||
| [104, 'occupancy', tuya.valueConverter.trueFalse1], | ||
| [105, 'state', tuya.valueConverterBasic.lookup({'ON': tuya.enum(0), 'OFF': tuya.enum(1), 'AUTO': tuya.enum(2)}) ] //Light motion setting |
There was a problem hiding this comment.
Suggested change
| [105, 'state', tuya.valueConverterBasic.lookup({'ON': tuya.enum(0), 'OFF': tuya.enum(1), 'AUTO': tuya.enum(2)}) ] //Light motion setting | |
| [105, 'light_mode', tuya.valueConverterBasic.lookup({'ON': tuya.enum(0), 'OFF': tuya.enum(1), 'AUTO': tuya.enum(2)}) ] //Light motion setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the Mercator Ikuu Combination sensor. The device reports more datapoints but I can't make sense of them.
This should fix the device support request here: Koenkk/zigbee2mqtt#19424