Update frient powermeter led 2 #8044
Open
+78
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Sep 29, 2024
src/devices/frient.ts
Outdated
| await entity.read('seMetering', ['develcoPulseConfiguration'], manufacturerOptions); | ||
| }, | ||
| } satisfies Tz.Converter, | ||
| interface_mode: { |
There was a problem hiding this comment.
Could you refactor this to extend? You can find an example in this PR: https://github.com/Koenkk/zigbee-herdsman-converters/pull/8043/files. This replaced the fz/tz and exposes.
There was a problem hiding this comment.
Hmmm.. perhaps, I'm searching for a more comprehensive example, where there are both getter and setter defined (ie both fromZigbee and toZigbee in the same modernExtend function).
There was a problem hiding this comment.
@Koenkk I think I got it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix Koenkk/zigbee2mqtt#19042