fix: Fill out missing Touchlink cluster info #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perfect ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating a Touchlink-related matter and noticed the spec was behind, so, added (most of) the missing stuff.
Figure this can start a bettering of the Touchlink controller in general (network commissioning & co), if someone is motivated 😉
(I don't have any Touchlink, so I won't be much help there)
It adds a new
ParameterCondition.FIELD_EQUALto match the Touchlink requirements for payload decoding.@Koenkk I included a cleanup of some related tests, I don't believe copying the raw clusters in the tests brings any real value, so might as well reduce the amount of data (by a lot!)... let me know what you think.