-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cluster.ts #1310
base: master
Are you sure you want to change the base?
Update cluster.ts #1310
Conversation
This cluster should be moved to custom clusters directly in |
Please use the custom cluster API instead as @Nerivec mentioned, see https://github.com/Koenkk/zigbee-herdsman-converters/blob/284e8557ac7bde72429daee2f168f89e0050d4cd/src/devices/sonoff.ts#L41 for an example. You can update this PR to remove the cluster entirely. |
@Koenkk , can this be merged until a new external converter using modernExtend customCluster is made ? The other PR on zhc related to this one has been merged and released in 2.1.0, but throw errors because this one is missing. Thanks |
The issue is only to move the custom LiXee cluster to ZHC. There are plenty of examples in recent PRs. Since the goal is to remove custom clusters from the ZigBee spec, they are all being moved whenever the occasion presents. |
Ok I think I got it. Have to test first. edit: @Nerivec, . I've spoke too fast, I won't be able to do that. There's too many thing I can't adapt, lost in Typescript. and this lixee.js is huge. I don't even know how to test correctly. ^^ |
How can I help? |
Add new attribute to LixeeCluster